Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change clientcore's baseline to Java 17 #43152

Merged
merged 11 commits into from
Dec 5, 2024
Merged

Change clientcore's baseline to Java 17 #43152

merged 11 commits into from
Dec 5, 2024
+840 −4,297

Conversation

alzimmermsft
Copy link
Member

Description

Changes the baseline Java version for clientcore packages to Java 17 and folds the JDK HttpClient HttpClient-based implementation into the core library.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Dec 2, 2024
@github-actions github-actions bot added Azure.Core azure-core clientcore common common module used by all azure SDKs (e.g. client, Mgmt) labels Dec 2, 2024
@alzimmermsft alzimmermsft marked this pull request as ready for review December 3, 2024 22:05
@alzimmermsft alzimmermsft requested a review from benbp December 5, 2024 18:26
@alzimmermsft alzimmermsft merged commit 259567d into Azure:main Dec 5, 2024
36 checks passed
@alzimmermsft alzimmermsft deleted the AzCC_BaselineJava17 branch December 5, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity samvaity approved these changes

@benbp benbp benbp approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core clientcore common common module used by all azure SDKs (e.g. client, Mgmt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @benbp @samvaity